Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin SDK] add docs for sponsored txns... #701

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

astinz
Copy link
Contributor

@astinz astinz commented Nov 9, 2024

Description

This PR introduces detailed documentation for implementing sponsored transactions in the Kotlin SDK.

Checklist

  • Linting & Formatting
    • Have you run pnpm spellcheck?
    • Have you run pnpm fmt?
    • Have you run pnpm lint?

@astinz astinz requested review from gregnazario and a team as code owners November 9, 2024 16:28
Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 4:30am

You can collapse the fee payer signing and submitting steps into one by using the `signAndSubmitAsFeePayer` method.

```kotlin
val committedTxn = aptos.signAndSubmitAsFeePayer(signer, aliceAuthenticator, txn)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the previous examples, the variable signer should be renamed to sponsor, as that's how the fee payer account is referenced throughout the documentation.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update this to say sponsor. This bot seems pretty decent :)

Copy link
Collaborator

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise, let me know when you fix the signer -> sponsor

You can collapse the fee payer signing and submitting steps into one by using the `signAndSubmitAsFeePayer` method.

```kotlin
val committedTxn = aptos.signAndSubmitAsFeePayer(signer, aliceAuthenticator, txn)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update this to say sponsor. This bot seems pretty decent :)

- for consistency, renamed signer to sponsor
@astinz
Copy link
Contributor Author

astinz commented Nov 15, 2024

guess we clear now, @gregnazario

@gregnazario gregnazario merged commit 3e8ad52 into aptos-labs:main Nov 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants